JCF: DUNE-DAQ/daqdataformats#79: drop references to daqdataformats::T…

[jcfreeman2]

…riggerRecordHeader::operator[] in unit tests due to its removal

Description

Basically, in the unit tests we drop references to daqdataformats::ComponentRequest::operator[] as this function has been removed for reasons described in DUNE-DAQ/daqdataformats#81.

To review, make sure the code continues to build and its unit tests pass while building alongside the johnfreeman/daqdataformats_issue79_code_refactoring branch of daqdataformats

This is meant to be merged at the same time as DUNE-DAQ/daqdataformats#81.

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature or enhancement (non-breaking change which adds functionality)
• Optimization (non-breaking change that improves code/performance)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

I suppose this is an optimization in the sense that, once DUNE-DAQ/daqdataformats#81 is merged, dfmessages won't compile without it.

Testing checklist

• Unit tests pass (e.g. dbt-build --unittest)
• Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
• Full set of integration tests pass (dunedaq_integtest_bundle.sh)
• Python tests pass if applicable (e.g. python -m pytest)
• Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

• Code is commented where needed, particularly in hard-to-understand areas
• Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
• If applicable, new tests have been added or an issue has been opened to tackle that in the future.
  (Indicate issue here: # (issue))

[jcfreeman2]

Closing this as I'm reconsidering the removal of daqdataformats::ComponentRequest::operator[]

[jcfreeman2]

Reopening (although still in Draft form) in light of daqdataformats commit 45a02b2c8748 in DUNE-DAQ/daqdataformats#81