Skip to content

JCF: Issue #100: clang-format the code#102

Merged
jcfreeman2 merged 1 commit into
developfrom
johnfreeman/issue100_clang-format
Apr 28, 2026
Merged

JCF: Issue #100: clang-format the code#102
jcfreeman2 merged 1 commit into
developfrom
johnfreeman/issue100_clang-format

Conversation

@jcfreeman2
Copy link
Copy Markdown
Contributor

@jcfreeman2 jcfreeman2 commented Apr 28, 2026

Description

This is a followup to the refactoring performed in PR #101; both this and that PR are part of addressing Issue #100. It's simply the effect of running dbt-clang-format.sh over the code + one line where I needed to add // NOLINT(build/unsigned) because of a line break the script introduced.

Eye test should be sufficient.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

I did skip integration testing as this is a dbt-clang-format.sh whitespace modification right on the heels of the fully-tested PR #101.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2 jcfreeman2 merged commit 7016928 into develop Apr 28, 2026
4 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/issue100_clang-format branch April 28, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants