Skip to content

Theo/ts rate fix#134

Open
xinyue-uoft wants to merge 5 commits into
developfrom
theo/ts_rate_fix
Open

Theo/ts rate fix#134
xinyue-uoft wants to merge 5 commits into
developfrom
theo/ts_rate_fix

Conversation

@xinyue-uoft
Copy link
Copy Markdown
Contributor

@xinyue-uoft xinyue-uoft commented Apr 29, 2026

Description

Addressing the issue #74 .

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Integration test note: daqsystemtest::3ru_1df_multirun_test

Across three sequential runs of this integration test, the
resulting HDF5 files contain 139, 140, and 140 trigger records respectively,
while the test expects 132.5 ± 6.5 (range 126.0–139.0). Two of the three runs
therefore overshoot the upper bound by 1 record and triggers the fail. All other
validations pass for these files. The remaining 5 of 6
subtests in 3ru_1df_multirun_test (WIBEth_System ×3, plus Software_TPG_System
test_nanorc_success and test_log_files) pass, and example_system_test had transient connection issue and pass on rerun. The shift appears consistent.

Note on Current develop branch:

max_file_size_test::test_tpstream_files failes by having 7 record files instead of 6. Same daqsystemtest::3ru_1df_multirun_test also persists.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@xinyue-uoft xinyue-uoft reopened this Apr 30, 2026
Kurt Biery and others added 4 commits April 30, 2026 05:08
…o use the total number expected so far to determine how many to generate, as a proof-of-concept.
…ports maximum of 64 channels times 32 alternating samples.
…ehaviour post fix should be nearly identical to pre-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant