Theo/ts rate fix#134
Open
xinyue-uoft wants to merge 5 commits into
Open
Conversation
…o use the total number expected so far to determine how many to generate, as a proof-of-concept.
…ports maximum of 64 channels times 32 alternating samples.
…ehaviour post fix should be nearly identical to pre-fix
fce9a34 to
9d336b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing the issue #74 .
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Integration test note: daqsystemtest::3ru_1df_multirun_test
Across three sequential runs of this integration test, the
resulting HDF5 files contain 139, 140, and 140 trigger records respectively,
while the test expects 132.5 ± 6.5 (range 126.0–139.0). Two of the three runs
therefore overshoot the upper bound by 1 record and triggers the fail. All other
validations pass for these files. The remaining 5 of 6
subtests in 3ru_1df_multirun_test (WIBEth_System ×3, plus Software_TPG_System
test_nanorc_success and test_log_files) pass, and example_system_test had transient connection issue and pass on rerun. The shift appears consistent.
Note on Current develop branch:
max_file_size_test::test_tpstream_files failes by having 7 record files instead of 6. Same daqsystemtest::3ru_1df_multirun_test also persists.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))