Skip to content

Added an integtest to verify correct running of the system when just a couple of TPG flags are turned off#318

Open
bieryAtFnal wants to merge 6 commits into
developfrom
kbiery/disabled_tpg_test
Open

Added an integtest to verify correct running of the system when just a couple of TPG flags are turned off#318
bieryAtFnal wants to merge 6 commits into
developfrom
kbiery/disabled_tpg_test

Conversation

@bieryAtFnal
Copy link
Copy Markdown
Contributor

Description

At the 23-Mar-2026 NP02 DAQ Operations meeting, Michal mentioned a bug in appmodel that caused problems when testing candidate software for fddaq-v5.6.0. He asked why the bug had not been caught in regression testing. (slides 12 and 13 in this presentation)

This PR is for a new regression test that would have caught the problem. I propose that we add this integtest to our test suite in the hope of catching similar problems in the future.

Here are suggestions for reviewing this new test. They include a demonstration that the test would have caught the appmodel bug from March.

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260501_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/disabled_tpg_test
git clone https://github.com/DUNE-DAQ/appmodel -b develop
cd ..

dbt-workarea-env
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -k disabled_tpg

echo ""
echo -e "\U1F535 \U2705 Note that the disabled_tpg_test worked fine with the latest appmodel code. \U2705 \U1F535"
echo ""
echo ""
sleep 3

cd sourcecode/appmodel
git checkout ba6d4d4
cd ../../

dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -k disabled_tpg

echo ""
echo -e "\U1F535 \U2705 Note that disabled_tpg_test reports lots of errors when run with the faulty appmodel code. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@bieryAtFnal bieryAtFnal marked this pull request as ready for review May 1, 2026 19:44
@bieryAtFnal bieryAtFnal requested a review from MRiganSUSX May 1, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants