Skip to content

Johnfreeman/issue79 clang format#82

Merged
jcfreeman2 merged 2 commits into
developfrom
johnfreeman/issue79_clang_format
Apr 21, 2026
Merged

Johnfreeman/issue79 clang format#82
jcfreeman2 merged 2 commits into
developfrom
johnfreeman/issue79_clang_format

Conversation

@jcfreeman2
Copy link
Copy Markdown
Contributor

Description

This is a whitespace change, courtesy of dbt-clang-format.sh; it can be considered part of Issue #79. Note that along with whitespace change I did need to move two // NOLINT directives which had been shifted to the "wrong" physical line.

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2 jcfreeman2 requested a review from eflumerf April 21, 2026 20:00
@jcfreeman2 jcfreeman2 merged commit d9564cf into develop Apr 21, 2026
5 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/issue79_clang_format branch April 21, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants