Add DAPHNEEth and DAPHNEEthStream support to generate_fakedata#621
Merged
Conversation
Add optional fragment_type parameter to generate_fakedata and handle det_id=2 (HD_PDS) for DAPHNEEthStream (frame_size=2008, time_tick_diff=280) and DAPHNEEth (frame_size=1864, time_tick_diff=1024). Previously only det_id=3 (WIBEth) was supported. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
13 tasks
bieryAtFnal
approved these changes
Mar 10, 2026
Contributor
bieryAtFnal
left a comment
bieryAtFnal
left a comment
There was a problem hiding this comment.
LGTM, tests pass, code changes look reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DUNE-DAQ/daqsystemtest#304 for details.