Run linting and code coverage in test workflow#345
Merged
Conversation
jcfreeman2
approved these changes
Mar 23, 2026
Collaborator
jcfreeman2
left a comment
There was a problem hiding this comment.
The changes are straightforward and the Action works (https://github.com/DUNE-DAQ/daq-buildtools/actions/runs/23448935833). Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the
test_daq_buildtools.ymlworkflow to run linting and code coverage steps. This was previously not the case due to the need ofllvmandlcov, which we resolve by bind mounting CVMFS into the nightly build container in which the test script runs. This same idea should also be applicable to single-package CI builds.When working on this, I noticed that
test_daq-buildtools.shwould hang indefinitely if given a malformed argument, such as--dbt-branch ${{ github.head_ref }}when${{ github.head_ref }}was invalid. I added a function totest_daq-buildtools.shwhich ensures that any flags passed also have a corresponding argument. I also made the argument passed to--dbt-branchdefault to${{ github.ref_name }}to further avoid invalid arguments.An example test run is here. Note that for this run, I prepended
timeto eachdbt-*command to see how long each took. It seems the initial loading of CVMFS is quite slow, sincedbt-setup-releasetook over 10 minutes. I'm not sure of a good way around this. Also, the test workflow should trigger when I open this PR.Please also include instructions for how a reviewer can test your changes.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))