Add linting to single-repo CI builds#16
Conversation
|
Could we also update the |
|
Thanks for the When I opened the PR, the resulting Action was https://github.com/DUNE-DAQ/cmdlib/actions/runs/23862915154. However, in the |
|
In order to test in an individual repo after merging, I've added a |
This PR enables the single-repo CI builds to run
dbt-build --lint. This is largely modeled off Eric's implementation in artdaq. The idea is to catch new linting errors introduced by pull requests without raising all previous linting errors (there are a lot in most repos). The nightly CI build will now upload an artifact callednightly_linting_results. Builds triggered by pull requests will uploadpull_request_linting_resultsand then compare this to the most recentnightly_linting_results. If thediff(or, to be more precise,comm -13) between the two is non-empty, the workflow will raise an error and uploadlinting_diffas an artifact.Notable changes:
caller_event_nameas a required input. This is necessary to distinguish scheduled (nightly) builds from those triggered by pull requests. Note that this means I'll need to sync the workflow files in each repository after this PR is merged.cvmfs-contrib/github-action-cvmfsto access CVMFS and, by extension,llvm.build_and_lint_package.shscript and run it in the appropriate container.sedmagic to simplify linting output for a cleandiff.For tests, see this example triggered by dummy pull request #136 in hdf5libs. For comparison, here is a scheduled test which mocks the nightly workflow, but uses this feature branch to include linting.