eventdev/rxa: fix integer truncation in eth_dev_id validation#117
Open
eventdev/rxa: fix integer truncation in eth_dev_id validation#117
Conversation
… telemetry handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eth_dev_idis declared asintinhandle_rxa_get_queue_conf,handle_rxa_get_queue_stats,handle_rxa_queue_stats_reset, andhandle_rxa_instance_get, but is implicitly narrowed touint16_twhenpassed to
rte_eth_dev_is_valid_portviaRTE_EVENT_ETH_RX_ADAPTER_PORTID_VALID_OR_GOTO_ERR_RET. This meansa value like 65535 + N passes validation as N, but is used as-is as
an array index, causing an out-of-bounds access and SIGSEGV.
To reproduce (requires
telemetryenabled):Result:
Fix: Change
eth_dev_idtype frominttouint16_t.