Skip to content

Other: Align error and warning syntax#2204

Open
sandro-elsweijer wants to merge 12 commits intomainfrom
align_error_and_warning_syntax
Open

Other: Align error and warning syntax#2204
sandro-elsweijer wants to merge 12 commits intomainfrom
align_error_and_warning_syntax

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Mar 3, 2026

Closes #2205

Describe your changes here:
The error and warning messages were all over the place, so I aligned them to be capitalized for easier readability.
A new check makes sure, that this is also enforced for future error and warning messages.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review March 4, 2026 09:58
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 10.29412% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.25%. Comparing base (a4ae425) to head (eb645e0).

Files with missing lines Patch % Lines
src/t8_cmesh/t8_cmesh_io/t8_cmesh_save.cxx 0.00% 14 Missing ⚠️
src/t8_cmesh/t8_cmesh_io/t8_cmesh_readmshfile.cxx 0.00% 11 Missing ⚠️
src/t8_vtk/t8_vtk_write_ASCII.cxx 8.33% 11 Missing ⚠️
src/t8_cmesh/t8_cmesh_io/t8_cmesh_triangle.cxx 0.00% 6 Missing ⚠️
..._geometry_implementations/t8_geometry_lagrange.cxx 0.00% 6 Missing ⚠️
src/t8_vtk/t8_vtk.c 0.00% 6 Missing ⚠️
src/t8_cmesh/t8_cmesh.cxx 0.00% 3 Missing ⚠️
src/t8_cmesh/t8_cmesh_internal/t8_cmesh_copy.c 0.00% 1 Missing ⚠️
src/t8_geometry/t8_geometry.cxx 0.00% 1 Missing ⚠️
src/t8_geometry/t8_geometry_base.hxx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@               Coverage Diff               @@
##           fix-scripts    #2204      +/-   ##
===============================================
+ Coverage        78.23%   78.25%   +0.01%     
===============================================
  Files              114      114              
  Lines            19034    19050      +16     
===============================================
+ Hits             14891    14907      +16     
  Misses            4143     4143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix-scripts to main March 4, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant