Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces compatibility checks and workarounds related to Python 3.14, primarily due to the
pythonnetandmikeio1ddependencies not yet supporting this version. The main changes ensure that the codebase handles environments running Python 3.14, both in CI and in user-facing code, and that tests are skipped or adjusted accordingly.Python 3.14 compatibility adjustments:
.github/workflows/docs.yml) to use Python 3.13 for documentation builds, with a comment explaining the dependency limitation.Network.from_res1d(src/modelskill/network.py), added a runtime check that raisesNotImplementedErrorif Python 3.14 or newer is detected, with a clear error message about the version requirement.sysimport insrc/modelskill/network.pyto support version checking.Testing adjustments:
tests/test_network.py, added a test (test_open_res1d) that is skipped on Python 3.14 or newer, ensuring tests do not fail due to unsupported dependencies. [1] [2]tests/notebooks/test_notebooks.py) to includeCollection_systems_network, with a comment explaining the Python 3.14 limitation.