Skip to content

[NOTASK] Recommendation ref refactoring#3352

Draft
Yannick1712 wants to merge 1 commit intodevelopfrom
feature/NOTASK-recommendation-ref-refactoring
Draft

[NOTASK] Recommendation ref refactoring#3352
Yannick1712 wants to merge 1 commit intodevelopfrom
feature/NOTASK-recommendation-ref-refactoring

Conversation

@Yannick1712
Copy link
Member

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

@Yannick1712 Yannick1712 requested a review from davidleomay March 4, 2026 15:29
Comment on lines +191 to +194
.then((rs) =>
rs.find(
(r) => r.isConfirmed && r.type === RecommendationType.INVITATION && r.method === RecommendationMethod.MAIL,
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not in SQL query?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants