fix: review nationality step immediately instead of waiting for cron#3226
Merged
TaprootFreak merged 4 commits intodevelopfrom Mar 5, 2026
Merged
fix: review nationality step immediately instead of waiting for cron#3226TaprootFreak merged 4 commits intodevelopfrom
TaprootFreak merged 4 commits intodevelopfrom
Conversation
The nationality review check is trivial (blocked/merged user, allowed nationality) and can be performed inline when the user submits their data, eliminating the up-to-1-minute wait for the cron job to process the step.
2 tasks
Eliminate code duplication between updateNationalityStep (inline review) and reviewNationalityStep (cron job) by extracting the review logic into a single private helper method.
The nationality path is now handled by the dedicated updateNationalityStep method, so the if (data.nationality) branch in updateKycStep is unreachable.
Yannick1712
reviewed
Feb 20, 2026
Address review feedback: instead of first saving with INTERNAL_REVIEW and then immediately changing the status, determine the final status inline and save data + status in one DB write. This eliminates the unnecessary intermediate INTERNAL_REVIEW state and reduces DB writes and step logs from 2 to 1 for non-residence-permit countries.
davidleomay
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateNationalityStep()method that performs the nationality review inline when the user submits their datareviewNationalityStepcron job to process the stepreviewNationalityData()helper method, used by both the inline review and the cron job — no code duplicationupdateKycStep()(no longer reachable)Test plan
ignored/manualReviewstatusmanualReviewINTERNAL_REVIEW(requires residence permit)