ui: Add settings button to the editor UI tab panel#1051
Open
Flohhhhh wants to merge 7 commits intoCyberTimon:mainfrom
Open
ui: Add settings button to the editor UI tab panel#1051Flohhhhh wants to merge 7 commits intoCyberTimon:mainfrom
Flohhhhh wants to merge 7 commits intoCyberTimon:mainfrom
Conversation
Mount SettingsPanel from App behind a full-screen overlay so splash and in-session flows share one path. Add a bottom control on the editor right rail (Cog + tooltip) and wire splash gear to the same opener. Center and pad the overlay content for readability. Clear the overlay when returning to the library or home so it cannot stick open. Defer reading theme CSS variables into the Editor WGPU ref until after the current commit finishes passive effects, so child effects no longer observe stale :root tokens before App applies the new theme (fixes wrong letterbox colors until navigation). Rename the settings header back tooltip from "Go to Home" to "Back". Refs: CyberTimon#128 Made-with: Cursor
Resolve conflicts: keep FileInput for export context menu (upstream) and merge RightPanelSwitcher lucide imports (panel icons from upstream, Cog for app settings from feature branch). Made-with: Cursor
Contributor
Author
|
Resolved conflict with compact UI improvements by just hiding the new settings button on compact screens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128
Description
I added access to the settings from the editor UI by adding a button on the bottom of the tab panel all the way to the right.
In order to do this I had to make the settings page a standalone page instead of part of the home layout. Hopefully that's alright? Let me know what you think!
Type of Change
Changes Made
SettingsPanelopened from both splash (gear) and editor (bottom-of-right-rail control), sharing the samehandleSettingsChange/rootPath/ refresh behavior.aria-label) so settings are reachable without going home first (issue #128).Also: padded, width-capped overlay layout; overlay cleared on home / back-to-library; deferred WGPU read of theme CSS variables after passive effects so editor theme switches don’t leave stale letterbox colors; settings back tooltip set to “Back” instead of “Go to Home”.
Screenshots/Videos
Testing
Test Configuration:
Checklist
AI Disclaimer:
Please state the involvement of AI in this PR: