Improve top banner presets and CSS isolation#1
Merged
Conversation
The banner editor now separates fixed notification presets from editable animation presets, adds dismissible/type controls, and scopes custom CSS to code-mode banners so CSS trials cannot leak into preset colors. The main layout also hosts the banner inside the rounded content frame to avoid visual overlap. Constraint: Banner customization must remain hot-debug friendly and avoid Docker rebuilds during UI iteration Rejected: Keep visual builder alongside CSS mode | CSS mode now covers the same effects with less duplicated UI and fewer conflicting styling paths Rejected: Let notification presets share palette colors | maintenance stripes and semantic alert colors become inconsistent when palette variables override fixed styles Confidence: high Scope-risk: moderate Directive: Keep custom banner CSS scoped to data-banner-mode=code unless preset bleed is explicitly desired and tested Tested: bun run build Tested: go test ./controller ./model ./router Not-tested: bun run typecheck still fails on pre-existing src/context/theme-color-provider.tsx DEFAULT_HUE unused error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run buildgo test ./controller ./model ./routerKnown gap
bun run typecheckstill fails on the pre-existingsrc/context/theme-color-provider.tsxunusedDEFAULT_HUEerror; this PR does not introduce that issue.