Open
Conversation
github-actions
bot
added
A-p2p
SyntheticBird45
requested changes
Apr 7, 2026
Member
There was a problem hiding this comment.
waiting on @Boog900 for one of the requested change. Will approve once it is resolved.
Edit: resolved
SyntheticBird45
approved these changes
Apr 9, 2026
| match s.as_str() { | ||
| "" => Ok(Self::Disabled), | ||
| "Tor" => Ok(Self::Tor), | ||
| // TODO: use `if let` guard when on >=1.95 |
Member
There was a problem hiding this comment.
https://blog.rust-lang.org/2026/04/16/Rust-1.95.0/
if-let guards in matches
Rust 1.88 stabilized let chains. Rust 1.95 brings that capability into match expressions, allowing for conditionals based on pattern matching.
Contributor
Author
There was a problem hiding this comment.
wen workspace: Rust 1.93..=1.95 PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #579
Why
no unparsed string :)
Where
cuprated, p2p
How
Add a
TryFrom<String>impl that parses "", "Tor", falls through to attempting to parse anything else as a SOCKS5 proxy url, checking if each part is correctAlso
From<ProxySettings>forStringfor test compatibility