feat: add client-side TLS support for Vault gRPC connection#25
Draft
jh-lee-cryptolab wants to merge 6 commits intomainfrom
Draft
feat: add client-side TLS support for Vault gRPC connection#25jh-lee-cryptolab wants to merge 6 commits intomainfrom
jh-lee-cryptolab wants to merge 6 commits intomainfrom
Conversation
Vault gRPC server now requires TLS by default (rune-admin #25). Add 3-tier channel selection: insecure (VAULT_TLS_DISABLE=true), secure with custom CA (VAULT_CA_CERT), or secure with system CA (default). Updates VaultConfig, vault_client, server call sites, config template, configure flow, install script, and test fixtures. Closes #24 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…figure.md Add follow-up prompts, error handling, descriptive labels, and Vault TLS status to the completion summary so both configure commands have the same level of detail for the TLS setup flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers cleanup of previously installed versioned plugins and the `claude plugin marketplace add ./rune` workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Without this, credential collection step cannot interactively prompt the user during /rune:configure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- _init_pipelines: forward ca_cert and tls_disable to fetch_keys_from_vault - health_check HTTP fallback: apply CA cert / tls_disable to httpx client Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorder credential collection (enVector first, Vault second) and add TLS configuration options to match commands/claude/configure.md. Also clean up gemini-extension.json settings and hooks.json format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
All paths verified in claude. Gemini and codex should be verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ca_certandtls_disablesettings through config, env vars, and server initializationrune/configure.tomlandclaude/configure.mdwith detailed follow-up prompts, error handling, and completion summaryChanged files
mcp/adapter/vault_client.py—secure_channelwith optional custom CA,insecure_channelonly whentls_disable=truemcp/server/server.py— Thread TLS params throughfetch_keys_from_vaultandVaultClientinitagents/common/config.py— Parse/saveca_certandtls_disableinVaultConfigconfig/config.template.json— Addca_certandtls_disablefieldscommands/claude/configure.md— TLS question flow with self-signed, public CA, no-TLS optionscommands/rune/configure.toml— Same TLS detail level asconfigure.mdscripts/install.sh— Create~/.rune/certs/directory during installmcp/tests/test_server.py— Add_ca_certand_tls_disabletoFakeVaultClientTest plan
VaultClientconnects with system CA (public CA mode)VaultClientloads custom CA PEM and connects (self-signed mode)VaultClientfalls back to insecure channel whentls_disable=true/rune:configureand confirm TLS question flow works end-to-endCloses #24