Open
Conversation
TLS is required by default (fail-secure). Server refuses to start without certificates unless VAULT_TLS_DISABLE=true is set. - Add _load_tls_credentials() to vault_grpc_server.py - Add docker-entrypoint.sh for auto self-signed cert generation - Add scripts/generate-certs.sh for manual cert generation - Update Dockerfile with openssl, entrypoint, /app/certs - Add TLS env vars to docker-compose.yml, vault-deployment.yml - Update .env.example and README.md with TLS documentation Closes #17 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Container starts as root to fix ownership on bind-mounted volumes (certs, vault_keys), then drops to the vault user via gosu. This follows the same pattern as postgres/redis official images. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Vault container handles TLS natively via docker-entrypoint.sh, so nginx/ngrok proxying is unnecessary. Bind gRPC port to 0.0.0.0 for direct TLS connections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Certificates generated without the actual server hostname/IP in SAN cause TLSV1_ALERT_UNKNOWN_CA on client connections. Now the script auto-detects the public IP via ifconfig.me and includes both the hostname argument and public IP in the certificate SAN. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VAULT_TLS_DISABLE=true)scripts/generate-certs.shfor manual cert generation (CA 4096-bit + server 2048-bit with SAN)vault_client.py) deferred to a separate issueChanges
vault/vault_grpc_server.py_load_tls_credentials()+serve_grpc()usesadd_secure_port()/add_insecure_port()vault/docker-entrypoint.shVAULT_TLS_CERT/VAULT_TLS_KEYvault/Dockerfileopenssl, entrypoint,/app/certsdirectoryscripts/generate-certs.shvault/.env.exampleVAULT_TLS_CERT,VAULT_TLS_KEY,VAULT_TLS_DISABLE)vault/docker-compose.yml./certs:/app/certs:rwvolumevault/vault-deployment.ymltls-certsvolumeMount +vault-tlsSecret (optional).gitignorecerts/directory patternvault/README.mdEnv Vars
VAULT_TLS_CERTVAULT_TLS_KEYVAULT_TLS_DISABLEtruefor insecure modeTest Results (on production server)
Tested by building the TLS image and running a separate container on port 50061 alongside the existing production server (50052), without disrupting it.
TLS configured, TLSv1.3 AES_256_GCM_SHA384)_InactiveRpcError)SERVING)VAULT_TLS_DISABLE=true→ insecure modeOut of Scope
rune/mcp/adapter/vault_client.py):insecure_channel→secure_channelwithVAULT_CA_CERTsupport — requiresrune installUX changes, tracked separatelyCloses #17