Merged
Conversation
gnuykeat
reviewed
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MSVC-friendly build support while introducing a secure memory-zeroing routine and fixing an off-by-one/range issue in rejection sampling.
Changes:
- Add
safe_memzero()implementation and routesafe_free()through it. - Adjust rejection sampling loop bounds to avoid underflow and correct the sampling range.
- Update tests/CMake/README for MSVC compatibility (VLA removal in tests, conditional
libmlinking).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functionality-test.c | Removes VLA usage (MSVC-incompatible) by switching to heap allocation; adjusts test constants/macros. |
| src/alea.c | Fixes rejection sampling loop bounds/range calculation. |
| src/alea-internal.h | Declares safe_memzero() and updates safe_free() to use it. |
| src/alea-internal.c | Adds cross-platform secure memory-zeroing implementation. |
| README.md | Reformats build options table (currently with markdown issues). |
| CMakeLists.txt | Adds alea-internal.c, makes libm conditional, adds MSVC link option. |
| .pre-commit-config.yaml | Bumps pre-commit hook versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juny2400
reviewed
Mar 12, 2026
juny2400
reviewed
Mar 12, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: SeungjunLee <juny2400@cryptolab.co.kr>
juny2400
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe_memzerofunction