fix(models): ApiKey.akKEY + ApiMaster.amKEY are TEXT, not STRING (#318)#319
Merged
Conversation
Migration 20260518000000-hash-api-keys.js changed both columns from `uuid` to `text` so they can hold a SHA-256 hex digest (64 chars) without a length cap. The Sequelize models were left at `Sequelize.STRING`, which Sequelize defaults to `VARCHAR(255)`. This doesn't break runtime — 64-char hashes fit comfortably in varchar(255) — but it leaves the model out of sync with the authoritative DB schema. Any operator running `sequelize.sync()` or piping the model definitions through schema-introspection tooling would get the wrong column type back. Align both models to `Sequelize.TEXT` and document the migration reference inline so future readers can follow the trail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318.
Summary
Aligns both auth-key models to the DB column type changed by
20260518000000-hash-api-keys.js. Runtime-safe; this just keepssequelize.sync()and schema-introspection tooling in agreement with the DB.Test plan
npm run lint && npm test— 781 passing (unchanged; runtime-equivalent change).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/