test(rate-limit): cover the req.socket.remoteAddress fallback branch#291
Merged
Merged
Conversation
#287 swapped the deprecated \`req.connection\` for \`req.socket\` in the rate-limit key generator's fallback path. The existing unit tests inject a plain { ip } object and never traverse the fallback, so the new accessor was technically untested. Add an explicit case that forces the fallback by passing { socket: { remoteAddress: ... } } without req.ip — the keygen should pick the socket address up and route it through the IPv6-aware helper. Test count: 760 → 761. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#287 swapped the deprecated
req.connectionforreq.socketin the rate-limit key generator's fallback path. The existing unit tests inject a plain{ ip }object and never traverse the fallback, so the new accessor was technically untested.This PR adds an explicit case that forces the fallback by passing
{ socket: { remoteAddress: ... } }withoutreq.ip— the keygen should pick the socket address up and route it through the IPv6-aware helper.Test plan
npm run lint && npm test— 761 passing (was 760).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/