Skip to content

chore(rate-limit): use req.socket instead of deprecated req.connection #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

chore(rate-limit): use req.socket instead of deprecated req.connection #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/middleware/rate-limit-key.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ function keyByAuthKeyOrIp(req /*, res */) {
// /56 network prefix (the helper's default). Fall back to
// 'unknown' when no source IP is available (e.g. unit-test
// fixtures or non-IP transports).
const ip = req.ip || (req.connection && req.connection.remoteAddress);
//
// `req.socket.remoteAddress` is the modern accessor — Node has
// marked `req.connection` deprecated (legacy alias for socket)
// since 13.x. Same value, future-proof name.
const ip = req.ip || (req.socket && req.socket.remoteAddress);
if (!ip) return 'ip:unknown';
return 'ip:' + ipKeyGenerator(ip);
}
Expand Down