chore(models): strip trailing whitespace + standardize "use strict" in legacy models#184
Merged
CryptoJones merged 1 commit intoMay 19, 2026
Conversation
… in the 3 legacy models apikey, apimaster, and customer were the first three model files written and pre-date the codebase's current style conventions: - `'use strict';` (single-quoted) vs every other model's `"use strict";` (double-quoted) - Trailing whitespace on every property line — disagrees with `.editorconfig`'s `trim_trailing_whitespace = true` for `*.js`, so the first contributor with an EditorConfig-aware editor would see a noisy diff on save unrelated to the change they're making. Pure mechanical cleanup. No behavior change: - Sequelize field declarations untouched (still no `allowNull` / `defaultValue` overrides — those would be real behavior changes the DDL in `setup/TimeTracker.sql` is authoritative for). - Module shape, options block, `defaultScope`, `tableName` all preserved verbatim. - 632 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CryptoJones
deleted the
chore/models-strip-trailing-whitespace-and-standardize-use-strict
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183.
Summary
The 3 oldest model files (
apikey,apimaster,customer) used'use strict';(single-quoted) and carried trailing whitespace onevery field. The other 15 models follow the current convention:
"use strict";(double-quoted) and no trailing whitespace per.editorconfig.Mechanical cleanup only. Field declarations stay verbatim — no
allowNull/defaultValueadditions (those would be real behaviorchanges, and the DDL is authoritative for what the DB enforces).
Test plan
npm run lintcleannpm test— 632 passed (no test surface affected)allowNull/defaultValueadditionsdefaultScope,tableNameunchangedProudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/