Updating ABDesigner with new ABViewDataView plugin#347
Merged
Conversation
johnny-hausman
added
the
patch
| // var L = UIClass.L(); | ||
| // var L = ABViewContainer.L(); | ||
|
|
||
| return class ABAbviewdataviewEditor extends ABViewEditorPlugin { |
Contributor
There was a problem hiding this comment.
Small thing I wanted to double-check here before merging:
I was expecting the Dataview editor to stay on the container-style editor path, similar to the existing designer-side Dataview/Detail behavior, but this version is inheriting from the generic plugin editor base instead.
Was that intentional? I just want to confirm this won’t affect Dataview edit-mode behavior, especially around subview/dashboard-style interactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we create a new plugin for ab_platform_web, we also need to include the ABDesigner properties and editors that we want to bundle as well.
here they are.
NOTE: it seems like we didn't include the ABDesigner updates for the ABViewDetail plugin, so they are also included with this PR as ABViewDataView depends on ABViewDetail.