[MPDX-9560] - Rename MHA Calculation Form to MHA Calculation Tool

[wjames111]

Description

• Renames the "MHA Calculation Form" menu item and page title to "MHA Calculation Tool" to match updated product terminology.
• Updates the HR Tools nav item label in useHrToolsNavItems.
• Updates the <title> tag on the MHA Calculator page.
• Updates affected tests (NavMenu.test.tsx, MultiPageMenu.test.tsx) to match the new label.

Related ticket: MPDX-9560

Testing

• Sign in and open the top nav HR Tools menu.
• Verify the entry previously labeled "MHA Calculation Form" now reads "MHA Calculation Tool".
• Click the entry and confirm it navigates to the MHA Calculator page.
• Verify the browser tab title shows "... | HR Tools | MHA Calculation Tool".
• Open the HR Tools sidebar (MultiPageMenu) and confirm the same label appears there.

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Bundle sizes [mpdx-react]

Compared against 1dea58b

No significant changes found

[wjames111]

Multi-Agent Code Review — APPROVED WITH SUGGESTIONS

Mode: standard · Risk: 2/10 (LOW) · Agents: Architecture, Testing, Standards, UX

A pure label rename ("MHA Calculation Form" → "MHA Calculation Tool") across 4 coordinated files. The rename is mechanically complete in source code; consuming tests are updated in lockstep. No blockers found.

---

Findings on Related Files (Not in This PR)

The rename creates a copy inconsistency in a sibling Salary Calculator component that wasn't touched by this PR. Cannot be posted as a line comment, so flagging here for awareness.

[Medium] src/components/HrTools/SalaryCalculator/Shared/SalaryInformationCard.tsx:106 — Cross-link still reads t('View MHA Form')

• Severity: 6.5/10
• Flagged by: UX Agent
• After this rename, the Salary Calculator's cross-link to the MHA tool still says "View MHA Form" while the destination's nav item and browser tab now read "MHA Calculation Tool." The mismatch is small (the destination page does contain a request form) but worth a product/copy call.
• Suggested fix (judgment call):

  - {t('View MHA Form')}
  + {t('View MHA Tool')}

  Plus matching test assertions in SalaryInformationCard.test.tsx:52,66 and NewSalaryCalculatorLanding.test.tsx:48,74.
• Defensible to leave if product intends "Form" to refer to the inner request form (the page's H1 is still t("Minister's Housing Allowance Request")).

---

Informational Notes

• i18n: The new keys 'MHA Calculation Tool' and 'HR Tools | MHA Calculation Tool' are not yet in public/locales/en/translation.json (the old keys are still at lines 1393/1719). This matches the precedent from commit 053c4cdd2 — translations are managed by CrowdIn / yarn extract, not edited in PRs. Confirm the extract+CrowdIn pipeline runs before release so production English doesn't fall back to the key string.
• [Pre-existing] [Sev 3.5] src/hooks/useHrToolsNavItems.ts has no colocated test file. The renamed string is indirectly covered by NavMenu.test.tsx and MultiPageMenu.test.tsx, so this is not a regression — worth a future cleanup ticket.
• [Sev 3.0] pages/.../mhaCalculator/index.page.test.tsx does not assert on document.title. Adding a <title> assertion would protect future regressions on the browser tab string.
• [Sev 3.0] Confirming intent: the page H1 remains t("Minister's Housing Allowance Request") — a deliberate, semantically-correct choice (the page hosts a request form inside the renamed Tool). No change requested; flagging only to confirm.

---

Agent Summary

Agent	Critical	High	Important	Suggestions	Confidence
Architecture	0	0	0	0	High
Testing	0	0	0	2	High
Standards	0	0	0	1 i18n WARN	High
UX	0	0	0	1 Medium + 1	High

Debate skipped — no findings reached severity 7 and the PR is a 4-line rename.

[github-actions]

AI Review Auto-Approval

Risk Level: LOW (2/10)
Verdict: APPROVED_WITH_SUGGESTIONS (suggestions posted, no blockers)

This PR was auto-approved because:

• The multi-agent AI review determined it is low risk
• No blocking issues were found
• All suggestions have been posted as review comments for the developer to consider

If you believe this PR needs human review, dismiss this approval and request a review manually.

[github-actions]

Preview branch generated at https://MPDX-9560.d3dytjb8adxkk5.amplifyapp.com