Fix calculation of gross monthly pay by removing unnecessary multiplier#1771
Closed
zweatshirt wants to merge 3 commits into
Closed
Fix calculation of gross monthly pay by removing unnecessary multiplier#1771zweatshirt wants to merge 3 commits into
zweatshirt wants to merge 3 commits into
Conversation
Contributor
Bundle sizes [mpdx-react]Compared against d15e969 No significant changes found |
zweatshirt
added
Preview Environment
Contributor
|
Preview branch generated at https://fix-multiplier-bug.d3dytjb8adxkk5.amplifyapp.com |
wjames111
approved these changes
May 12, 2026
Contributor
wjames111
left a comment
wjames111
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the quick fix
wjames111
approved these changes
May 12, 2026
Contributor
Author
|
@wjames111 Looking at this deeper, I am pretty convinced this is actually a data issue (what's stored in the DB). I'm wondering where we might be able to get the table of geographic multipliers that was provided by stakeholders for MPD Goal Calc? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Geographic multiplier almost doubles because of the extra 1 in PDS Goal Calculator
Testing
pdsGoalCalculatorChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions