Skip to content

[MPDX-9539] Show MCC approval level from API#1768

Merged
canac merged 1 commit into
mainfrom
9539-api-approval-tier
May 13, 2026
Merged

[MPDX-9539] Show MCC approval level from API#1768
canac merged 1 commit into
mainfrom
9539-api-approval-tier

Conversation

@canac
Copy link
Copy Markdown
Contributor

@canac canac commented May 8, 2026

Description

Trust the approval level calculated by the API instead of calculating it ourselves.

Needed so that the approval level from https://github.com/CruGlobal/mpdx_api/pull/3315 will show in the UI.

MPDX-9539

Testing

  • Impersonate caleb.cox@cru.org
  • Open the in-progress ASR
  • Submit the request
  • Check that it says you need MCC approval

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@canac canac requested a review from wjames111 May 8, 2026 19:55
@canac canac self-assigned this May 8, 2026
@canac canac added the Preview Environment Add this label to create an Amplify Preview label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Preview branch generated at https://9539-api-approval-tier.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Bundle sizes [mpdx-react]

Compared against d15e969

No significant changes found

Copy link
Copy Markdown
Contributor

@wjames111 wjames111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think using just the approval level is a lot more straightforward.

@canac canac merged commit 7222699 into main May 13, 2026
44 checks passed
@canac canac deleted the 9539-api-approval-tier branch May 13, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants