Skip to content

MPDX-9545 Remove extra pending statuses from ASR#1766

Merged
kegrimes merged 1 commit into
mainfrom
MPDX-9545-remove-extra-pending-statuses
May 8, 2026
Merged

MPDX-9545 Remove extra pending statuses from ASR#1766
kegrimes merged 1 commit into
mainfrom
MPDX-9545-remove-extra-pending-statuses

Conversation

@kegrimes
Copy link
Copy Markdown
Contributor

@kegrimes kegrimes commented May 8, 2026

Description

Remove:

  • AsrStatusEnum.PendingDivisionHeadApproval:
  • AsrStatusEnum.PendingVpApproval:
  • AsrStatusEnum.PendingManagementApproval:
  • AsrStatusEnum.PendingBoardApproval

Will be merging a backend PR after this merges!

Testing

  • Go to /hrTools/additionalSalaryRequest
  • Make sure nothing broke

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@kegrimes kegrimes self-assigned this May 8, 2026
@kegrimes kegrimes added the Preview Environment Add this label to create an Amplify Preview label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Bundle sizes [mpdx-react]

Compared against 5869477

No significant changes found

@kegrimes kegrimes requested a review from canac May 8, 2026 18:00
Copy link
Copy Markdown
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Make sure to remove the statuses in src/components/HrTools/AdditionalSalaryRequest/AdditionalSalaryRequest.graphql too.

@kegrimes kegrimes force-pushed the MPDX-9545-remove-extra-pending-statuses branch from c329e49 to faf38e0 Compare May 8, 2026 19:10
@kegrimes kegrimes merged commit d15e969 into main May 8, 2026
24 checks passed
@kegrimes kegrimes deleted the MPDX-9545-remove-extra-pending-statuses branch May 8, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants