MPDX-9494 - Merge src/components/common into src/components/Shared and fix imports#1762
Conversation
|
Preview branch generated at https://merge-common-to-shared.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against dc942a7 No significant changes found |
a9bb400 to
fdab65e
Compare
|
I think this would be a great PR to trust an AI review on, but feel free to re-request a review if it denies it for some reason. |
|
@canac I tried, it came back as 10/10 critical. I'll try a second time quickly |
canac
left a comment
There was a problem hiding this comment.
Oh OK, sorry! I didn't see the AI review posted, so I didn't realize that you ran it locally.
No worries, bad habit on my end, I should let the AI review post. Good news is it came back clean. Just in case, I'll run it again 👍🏻 |
wjames111
left a comment
There was a problem hiding this comment.
Woah this is a lot, I think its a worthwhile change though. Everything looks good, but I didn't test extensively. If you feel confident we didn't break any paths, I'll take your word for it.
That's not necessarily a bad habit. Sometimes I run it locally, fix the issues, and then run and post to reduce noise on the PR. However you want to do it. |
zweatshirt
left a comment
There was a problem hiding this comment.
Multi-Agent Code Review Report
Agents: 4 specialized reviewers (Architecture, Testing, Standards, UX)
Mode: standard
Verdict: CLEAN
No issues found across architecture, testing, standards, or UX dimensions. This is a verified mechanical rename refactor.
Risk Assessment
- Pattern-score: 10/10 → CRITICAL (saturated by file-pattern matches across 258 files — every file matches a Medium- or High-Risk pattern in
.claude/rules/code-review.md) - Qualitative profile: MEDIUM — every changed line is a one-line import path swap; no business logic, no JSX, no GraphQL operations, no Apollo wiring touched
- Reviewer recommendation: ANY (qualitative basis) —
tsc/eslintcarry the correctness load on a mechanical rename
Independently-Verified Evidence
| Check | Result | Verifier |
|---|---|---|
grep -r "from 'src/components/common" across the repo |
0 matches | Architecture, Testing |
src/components/common/ directory |
Removed from disk | Architecture |
Cross-references inside Shared/ to old common/ |
0 | Architecture |
jest.mock('src/components/common/...') |
0 | Testing |
.snap files referencing old path |
0 | Testing |
__mocks__/ references stale |
0 | Testing |
yarn eslint over all 257 changed files |
0 errors, 16 pre-existing warnings (none on diff lines) | Standards |
yarn lint:ts |
clean | Standards |
| Git rename detection (R100, byte-identical) | 49 of 258 files | Standards |
Diff content audit — non-import +/- lines |
0 | UX, Architecture |
Translation files public/locales/ touched |
0 | UX |
| Public-API exports preserved | Yes (Modal, ActionButtons, Confirmation, OrganizationAutocomplete, ContactPanelProvider sampled) | Architecture |
Findings
- Critical Blockers (Severity 9.0–10.0): 0
- High Priority Blockers (Severity 8.0–8.9): 0
- Important Issues (Severity 7.0–7.9): 0
- Medium Priority (Severity 5.0–6.9): 0
- Suggestions (Severity < 5.0): 0
Technical Debt Analysis
- Removed: Eliminates the parallel "shared component" tree (
src/components/common/) that duplicated the role ofsrc/components/Shared/. Brings the codebase into alignment with the documentedCLAUDE.mdstandard ("Shared components are insrc/components/Shared/") and follows recent precedent from commita7a2fc87f("Merge src/utils into src/lib"). - Net Impact: Better.
Review Summary Table
| Agent | Critical | High | Important | Suggestions | Confidence |
|---|---|---|---|---|---|
| Architecture | 0 | 0 | 0 | 0 | High |
| Testing | 0 | 0 | 0 | 0 | High |
| Standards | 0 | 0 | 0 | 0 | High |
| UX | 0 | 0 | 0 | 0 | High |
| Total | 0 | 0 | 0 | 0 |
Note on auto-approval: the strict pattern-based risk_level is CRITICAL (saturated at 10 by file-pattern matches across 258 files). The auto-approve workflow only triggers on LOW/MEDIUM risk, so this PR will require a human approval despite the CLEAN verdict. The qualitative risk is MEDIUM — tsc and eslint are the strongest correctness signals for a mechanical rename, and both pass cleanly.
Description
Merges src/components/common with src/components/Shared to unify shared components into one directory.
Jira ticket
Testing
src/componentns/commonbefore this gets mergedChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions