Skip to content

MPDX-9494 - Merge src/components/common into src/components/Shared and fix imports#1762

Merged
zweatshirt merged 1 commit into
mainfrom
merge-common-to-shared
May 5, 2026
Merged

MPDX-9494 - Merge src/components/common into src/components/Shared and fix imports#1762
zweatshirt merged 1 commit into
mainfrom
merge-common-to-shared

Conversation

@zweatshirt
Copy link
Copy Markdown
Contributor

@zweatshirt zweatshirt commented May 5, 2026

Description

Merges src/components/common with src/components/Shared to unify shared components into one directory.

Jira ticket

Testing

  • Make sure app still behaves the exact same as it did before. Requires some user testing. Ultimately this is just a directory and import paths change, so it should be relatively safe as long as no new changes merge into main importing from src/componentns/common before this gets merged

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@zweatshirt zweatshirt self-assigned this May 5, 2026
@zweatshirt zweatshirt added the Preview Environment Add this label to create an Amplify Preview label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Preview branch generated at https://merge-common-to-shared.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Bundle sizes [mpdx-react]

Compared against dc942a7

No significant changes found

@zweatshirt zweatshirt force-pushed the merge-common-to-shared branch from a9bb400 to fdab65e Compare May 5, 2026 19:07
@zweatshirt zweatshirt changed the title Merge src/components/common into src/components/Shared and fix imports MPDX-9494 - Merge src/components/common into src/components/Shared and fix imports May 5, 2026
@zweatshirt zweatshirt marked this pull request as ready for review May 5, 2026 19:08
@zweatshirt zweatshirt requested review from canac and wjames111 May 5, 2026 19:17
@canac
Copy link
Copy Markdown
Contributor

canac commented May 5, 2026

I think this would be a great PR to trust an AI review on, but feel free to re-request a review if it denies it for some reason.

@canac canac removed their request for review May 5, 2026 19:18
@zweatshirt
Copy link
Copy Markdown
Contributor Author

zweatshirt commented May 5, 2026

@canac I tried, it came back as 10/10 critical. I'll try a second time quickly

Copy link
Copy Markdown
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, sorry! I didn't see the AI review posted, so I didn't realize that you ran it locally.

@zweatshirt
Copy link
Copy Markdown
Contributor Author

Oh OK, sorry! I didn't see the AI review posted, so I didn't realize that you ran it locally.

No worries, bad habit on my end, I should let the AI review post. Good news is it came back clean. Just in case, I'll run it again 👍🏻

Copy link
Copy Markdown
Contributor

@wjames111 wjames111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah this is a lot, I think its a worthwhile change though. Everything looks good, but I didn't test extensively. If you feel confident we didn't break any paths, I'll take your word for it.

@canac
Copy link
Copy Markdown
Contributor

canac commented May 5, 2026

No worries, bad habit on my end, I should let the AI review post. Good news is it came back clean. Just in case, I'll run it again 👍🏻

That's not necessarily a bad habit. Sometimes I run it locally, fix the issues, and then run and post to reduce noise on the PR. However you want to do it.

Copy link
Copy Markdown
Contributor Author

@zweatshirt zweatshirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-Agent Code Review Report

Agents: 4 specialized reviewers (Architecture, Testing, Standards, UX)
Mode: standard


Verdict: CLEAN

No issues found across architecture, testing, standards, or UX dimensions. This is a verified mechanical rename refactor.

Risk Assessment

  • Pattern-score: 10/10 → CRITICAL (saturated by file-pattern matches across 258 files — every file matches a Medium- or High-Risk pattern in .claude/rules/code-review.md)
  • Qualitative profile: MEDIUM — every changed line is a one-line import path swap; no business logic, no JSX, no GraphQL operations, no Apollo wiring touched
  • Reviewer recommendation: ANY (qualitative basis) — tsc/eslint carry the correctness load on a mechanical rename

Independently-Verified Evidence

Check Result Verifier
grep -r "from 'src/components/common" across the repo 0 matches Architecture, Testing
src/components/common/ directory Removed from disk Architecture
Cross-references inside Shared/ to old common/ 0 Architecture
jest.mock('src/components/common/...') 0 Testing
.snap files referencing old path 0 Testing
__mocks__/ references stale 0 Testing
yarn eslint over all 257 changed files 0 errors, 16 pre-existing warnings (none on diff lines) Standards
yarn lint:ts clean Standards
Git rename detection (R100, byte-identical) 49 of 258 files Standards
Diff content audit — non-import +/- lines 0 UX, Architecture
Translation files public/locales/ touched 0 UX
Public-API exports preserved Yes (Modal, ActionButtons, Confirmation, OrganizationAutocomplete, ContactPanelProvider sampled) Architecture

Findings

  • Critical Blockers (Severity 9.0–10.0): 0
  • High Priority Blockers (Severity 8.0–8.9): 0
  • Important Issues (Severity 7.0–7.9): 0
  • Medium Priority (Severity 5.0–6.9): 0
  • Suggestions (Severity < 5.0): 0

Technical Debt Analysis

  • Removed: Eliminates the parallel "shared component" tree (src/components/common/) that duplicated the role of src/components/Shared/. Brings the codebase into alignment with the documented CLAUDE.md standard ("Shared components are in src/components/Shared/") and follows recent precedent from commit a7a2fc87f ("Merge src/utils into src/lib").
  • Net Impact: Better.

Review Summary Table

Agent Critical High Important Suggestions Confidence
Architecture 0 0 0 0 High
Testing 0 0 0 0 High
Standards 0 0 0 0 High
UX 0 0 0 0 High
Total 0 0 0 0

Note on auto-approval: the strict pattern-based risk_level is CRITICAL (saturated at 10 by file-pattern matches across 258 files). The auto-approve workflow only triggers on LOW/MEDIUM risk, so this PR will require a human approval despite the CLEAN verdict. The qualitative risk is MEDIUM — tsc and eslint are the strongest correctness signals for a mechanical rename, and both pass cleanly.

@zweatshirt zweatshirt merged commit e03c543 into main May 5, 2026
24 checks passed
@zweatshirt zweatshirt deleted the merge-common-to-shared branch May 5, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants