Added CRUD endpoints for ResourceScores and ResourceDefaultOrders by hepu · Pull Request #1915 · CruGlobal/mobile-content-api

hepu · 2025-12-04T16:38:46Z

Summary

Adds CRUD-oriented routes for the API endpoints created for ResourceScore and ResourceDefaultOrder

Current routes

…atus

…endpoint for ranked resources

stage-branch-merger · 2025-12-15T15:38:21Z

I see you added the "On Staging" label, I'll get this merged to the staging branch!

stage-branch-merger · 2025-12-15T15:39:03Z

Merge conflict attempting to merge this into staging. Please fix manually.

stage-branch-merger · 2025-12-15T16:48:13Z

I see you added the "On Staging" label, I'll get this merged to the staging branch!

stage-branch-merger · 2025-12-16T21:51:16Z

I see you added the "On Staging" label, I'll get this merged to the staging branch!

stage-branch-merger · 2026-01-14T21:16:55Z

Merge conflict attempting to merge this into staging. Please fix manually.

stage-branch-merger · 2026-01-14T21:44:34Z

Merge conflict attempting to merge this into staging. Please fix manually.

stage-branch-merger · 2026-01-14T22:10:07Z

I see you added the "On Staging" label, I'll get this merged to the staging branch!

andrewroth · 2026-05-14T19:05:31Z

+    @resource_score = ResourceScore.find(params[:id])
+    @resource_score.destroy!
+    render json: {}, status: :ok
+  rescue


Below references e.message but no exception e (rescue => e) is done here.

andrewroth · 2026-05-14T19:11:48Z

+    @resource_default_order.destroy!
+    render json: {}, status: :ok
+  rescue
+    render json: {errors: [{source: {pointer: "/data/attributes/id"}, detail: e.message}]},


Below references e.message but no exception e (rescue => e) is done here.

andrewroth · 2026-05-14T19:28:02Z

+    resource_type = params.dig(:filter, :resource_type) || params[:resource_type]
+
+    if lang.present?
+      language = Language.where("code = :lang OR LOWER(code) = LOWER(:lang)", lang: lang).first


code = :lang is redundant if LOWER(code) = LOWER(:lang) (even better if it can be refactored to one method/scope)

andrewroth · 2026-05-14T19:28:07Z

+  def create
+    sanitized_params = create_params
+    if create_params[:lang].present?
+      language = Language.where("code = :lang OR LOWER(code) = LOWER(:lang)",


code = :lang is redundant if LOWER(code) = LOWER(:lang)

andrewroth · 2026-05-14T19:28:10Z

+    @resource_default_order = ResourceDefaultOrder.find(params[:id])
+    sanitized_params = create_params
+    if create_params[:lang].present?
+      language = Language.where("code = :lang OR LOWER(code) = LOWER(:lang)",


code = :lang is redundant if LOWER(code) = LOWER(:lang)

andrewroth · 2026-05-14T20:02:50Z

+    @resource_default_order.language = language if language.present?
+    @resource_default_order.save!
+    render json: @resource_default_order, status: :created
+  rescue => e


all of these => e catches should really grab a subset of errors like record not found etc. Otherwise, we end up catching errors that should go to a rollbar crash report (bugs).

andrewroth · 2026-05-14T20:11:48Z

+class ConvertResourceScoreLangToLanguageId < ActiveRecord::Migration[7.1]
+  def up
+    add_column :resource_scores, :language_id, :integer
+    add_index :resource_scores, [:language_id, :country]


Suggested change

add_index :resource_scores, [:language_id, :country]

add_index :resource_scores, [:resource_id, :language_id, :country], unique: true

I believe this won't break anything and is better than not having it. But whoever deploys this needs to query production data to make sure this will apply on production data.

andrewroth · 2026-05-14T20:14:31Z

+  end
+
+  def down
+    remove_index :resource_scores, [:language_id, :country] if index_exists?(:resource_scores, [:language_id, :country])


Suggested change

remove_index :resource_scores, [:language_id, :country] if index_exists?(:resource_scores, [:language_id, :country])

remove_index :resource_scores, [:resource_id, :language_id, :country] if index_exists?(:resource_scores, [:resource_id, :language_id, :country])

andrewroth · 2026-05-14T20:17:43Z

+class ConvertResourceDefaultOrderLangToLanguageId < ActiveRecord::Migration[7.1]
+  def up
+    add_column :resource_default_orders, :language_id, :integer
+    add_index :resource_default_orders, :language_id


Suggested change

add_index :resource_default_orders, :language_id

add_index :resource_default_orders, [:resource_id, :language_id], unique: true

andrewroth · 2026-05-14T20:18:11Z

+
+  def down
+    if column_exists?(:resource_default_orders, :language_id)
+      remove_index :resource_default_orders, :language_id


Suggested change

remove_index :resource_default_orders, :language_id

remove_index :resource_default_orders, [:resource_id, :language_id] if index_exists?(:resource_default_orders, [:resource_id, :language_id])

hepu added 15 commits November 5, 2025 10:13

Added ContentStatus ctrller

ebced1c

Using Language association with ResourceScore and ResourceDefaultOrder

51b6162

Merge branch 'feature/lang-model-association' into feature/content-st…

0add629

…atus

Updated Content Status response

ce1f9c3

Touching resource on score or default order update/creation

b1acd1d

Merge branch 'feature/mass-update-endpoint' into feature/content-status

75af30d

Added spec file

4f16f57

Updated spec for content_status

74333d3

Fixed unassigned scope on default_orders

3ee6646

Added mass_update endpoint for default orders and mass_update_ranked …

2ed61cc

…endpoint for ranked resources

Updated spec

b283daf

Updated queries

6d7424c

Fixed lints + Updated tests

3ba7024

Fixed lint issues

05f45b8

Added CRUD endpoints for ResourceScores

01f6df0

hepu self-assigned this Dec 4, 2025

hepu added 8 commits December 4, 2025 12:01

Fixed route

d251a4d

Updated brakeman.ignore

d333ba1

Fixed lint issues

c0ab607

Removed duplicated endpoints

bf90523

Removed unused code

e1365ed

Merge branch 'master' into feature/content-status

593da93

Fixed lint issues

c0bd2d6

Merge branch 'master' into feature/crud-endpoints

0eca39d

hepu changed the title ~~Added CRUD endpoints for ResourceScores~~ Added CRUD endpoints for ResourceScores and ResourceDefaultOrders Dec 10, 2025

Moved Default Orders to ResourceDefaultOrder endpoints

8d603ac

hepu requested review from andrewroth and frett December 10, 2025 18:05

hepu added 2 commits December 10, 2025 14:10

Adding validation for resource_type param

c86b9d4

Added language validation on default_orders#index

55b764e

hepu added 5 commits December 11, 2025 11:31

Fixed lint issue

6945db8

Added language validation on resource_default_orders#index

481dba5

Updated language query

b9fb4cc

Removed downcase from error msg

30640ed

Fixed last_update value

55a0e91

hepu added the On Staging label Dec 15, 2025

hepu added 2 commits December 15, 2025 11:04

Merge branch 'feature/content-status' into feature/crud-endpoints

69269b4

Adding back default_order route + added language fallback

ab8a3d3

hepu added On Staging and removed On Staging labels Dec 15, 2025

Fixed lang not found on default#mass_update

2fd0b62

hepu added On Staging and removed On Staging labels Dec 16, 2025

Ensuring mass_update endpoints remove all unselected resources

fbde6e6

hepu force-pushed the feature/crud-endpoints branch from 995d5c3 to fbde6e6 Compare January 14, 2026 21:54

hepu added On Staging and removed On Staging labels Jan 14, 2026

JasonBennett41 mentioned this pull request Jan 31, 2026

Mass Update Refactor #1940

Open

andrewroth requested changes May 14, 2026

View reviewed changes

	add_index :resource_scores, [:language_id, :country]
	add_index :resource_scores, [:resource_id, :language_id, :country], unique: true

	remove_index :resource_scores, [:language_id, :country] if index_exists?(:resource_scores, [:language_id, :country])
	remove_index :resource_scores, [:resource_id, :language_id, :country] if index_exists?(:resource_scores, [:resource_id, :language_id, :country])

	add_index :resource_default_orders, :language_id
	add_index :resource_default_orders, [:resource_id, :language_id], unique: true

	remove_index :resource_default_orders, :language_id
	remove_index :resource_default_orders, [:resource_id, :language_id] if index_exists?(:resource_default_orders, [:resource_id, :language_id])

Conversation

hepu commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Current routes

Uh oh!

stage-branch-merger Bot commented Dec 15, 2025

Uh oh!

stage-branch-merger Bot commented Dec 15, 2025

Uh oh!

stage-branch-merger Bot commented Dec 15, 2025

Uh oh!

stage-branch-merger Bot commented Dec 16, 2025

Uh oh!

stage-branch-merger Bot commented Jan 14, 2026

Uh oh!

stage-branch-merger Bot commented Jan 14, 2026

Uh oh!

stage-branch-merger Bot commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hepu commented Dec 4, 2025 •

edited

Loading