GT-2601: Download translation files from CDN with SHA-256 verification#4424
Open
frett wants to merge 4 commits into
Open
GT-2601: Download translation files from CDN with SHA-256 verification#4424frett wants to merge 4 commits into
frett wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4424 +/- ##
===========================================
+ Coverage 51.99% 52.06% +0.07%
===========================================
Files 454 455 +1
Lines 12075 12105 +30
Branches 2092 2096 +4
===========================================
+ Hits 6278 6303 +25
- Misses 5181 5188 +7
+ Partials 616 614 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… to API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiConfigto consolidate API/CDN base URL configuration, replacing the scattered@Namedstring injectionCdnApi(Retrofit) for downloading published translation files from the CDN, with base URLs configured per flavor (mobilecontent-stage.cru.org/mobilecontent.cru.org)TranslationsApion 4xx errors orIOExceptionTest plan
IOException, both sources failing returns false, correct/wrong SHA-256 accepted/rejected, correct/wrong size accepted/rejected./gradlew :library:download-manager:testto verify all download manager tests pass./gradlew :build-logic:ktlintCheck ktlintCheckto verify code style🤖 Generated with Claude Code