Migrate ABViewGrid#722
Open
benthongtiang wants to merge 3 commits into
Open
Conversation
benthongtiang
added
the
patch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const verticalScrollState = $DataTable.getScrollState().y, | ||
| rowHeight = $DataTable.config.rowHeight, | ||
| height = |
| if (!CurrentObject) return; | ||
|
|
||
| if (settings.isEditable === 0) { | ||
| const items = $DataTable.getItem(id); |
|
|
||
| const updateRow = async () => { | ||
| try { | ||
| const response = await CurrentObject.model().update( |
| * @param {event} event | ||
| */ | ||
| async onAfterColumnDrop(sourceId, targetId, event) { | ||
| const $DataTable = this.getDataTable(); |
| */ | ||
| async onAfterColumnDrop(sourceId, targetId, event) { | ||
| const $DataTable = this.getDataTable(); | ||
| const CurrentObject = this.datacollection.datasource; |
Contributor
Lighthouse Performance ReportMetrics📄Full Report |
| dc.on("loadData", this.__handler_dc_loadData); | ||
| this.grouping(); | ||
|
|
||
| this._isDatacollectionLoad = true; |
Contributor
There was a problem hiding this comment.
Is this _isDatacollectionLoad supposed to be the same as _isDatacollectionLoaded from line 147?
Also in line 993 in the component file
| selectRow(rowData) { | ||
| let id = rowData?.id ?? rowData; | ||
| if (this.__timeout_selectRow) { | ||
| console.log("Duplicate selectRow():", id); |
Contributor
There was a problem hiding this comment.
console.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the Grid View to the new plugin architecture and resolved a critical crash in the List data field when handling empty selections.
Relate PR.
CruGlobal/plugin_ABDesigner#349
CruGlobal/appbuilder_class_core#343