chore: include excluded repositories (CM-1006)#3887
Conversation
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
mbani01
left a comment
There was a problem hiding this comment.
@joanagmaia LGTM. To double-check, for health score pipes, we don't need the extended Gerrit channels, right? Otherwise, we should be using repos_to_channels instead of direct usage of repositories
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
@mbani01 Nice catch, you are absolutely right. This should be considered since Gerrit repositories would never return a match here. Currently this excluded is mainly being used on Github but we should still support Gerrit. Applied the changes, had to update the repos_to_channels pipe to include the exclude filter |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
20a840c to
304086f
Compare
This pull request removes the
excluded = falsecondition from several SQL queries and descriptions across multiple Tinybird pipes. The change makes the queries consider all enabled repositories, regardless of theirexcludedstatus. This simplifies repository filtering logic and ensures consistency in how repositories are selected throughout the analytics pipeline.Repository filtering logic updates:
r.excluded = falsecondition from theWHEREclauses in allactivityRelations_bucket_clean_enrich_copy_pipe_*files, so onlyenabledand not-deleted repositories are considered.Documentation and default behavior updates:
repos_to_channels.pipeto reflect that the default is now all enabled repositories, not just non-excluded ones.Reason for changes
The only place where we should exclude "excluded repositories" is from the main health score metrics and security ones, which is already achieved in
security_deduplicated_merged_copy_pipe.pipe, and with the latest changes on the health score pipes.Everywhere else (search repositories modal, contributors, popularity and development metrics) we should display excluded repos.
Original purpose of "excluded" boolean was to not consider these repos in Health Score and Security - This is also what's included in the documentation.
Note
Medium Risk
Changes repository-scoping SQL across multiple Tinybird pipes, which will alter which repos feed analytics and can shift health score/security results. Risk is moderate due to potential metric deltas and increased data volume, but the change is mostly filter adjustments.
Overview
Most Tinybird pipes that join against
repositoriesnow stop filtering onexcluded = false, so any enabled, non-deleted repo (including excluded ones) can appear in activity enrichment, project population, segment scoping, and repository search.Health score queries are updated to explicitly exclude excluded repos by adding
channel NOT IN (SELECT channel FROM repos_to_channels(excluded=True)), andrepos_to_channels.pipenow supports anexcludedparameter to expand excluded repos for that filter;health_score_security.pipealso enforcesr.excluded = falsewhen selecting repos to score.Written by Cursor Bugbot for commit 304086f. This will update automatically on new commits. Configure here.