SER-2859: Use consistent 'Push Actioned' label across Drill UI#7597
Open
mrmeghana wants to merge 2 commits into
Open
SER-2859: Use consistent 'Push Actioned' label across Drill UI#7597mrmeghana wants to merge 2 commits into
mrmeghana wants to merge 2 commits into
Conversation
In the Drill segmentation row, the Push tab was hardcoded as "Push Actioned" while the event button under "QUERY BASED ON" showed "Push action" (from the i18n string). Two different wordings for the same entity. Use the i18n key as the source of truth for the tab label (matching how Journey and other tabs work) and update the English default to "Push Actioned" so both spots stay in sync via a single string. Other-language locale files keep their existing translations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Cookiezaurs
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SER-2859
In the Drill UI, the push event was labelled inconsistently:
internal-events.[CLY]_push_action)helpers.js)Change
helpers.js: use the i18n key as the source of truth for the tab label (matching how Journey and other tabs already work). Replaces a hardcoded"Push Actioned".push.properties(English default): change the canonical value fromPush actiontoPush Actionedso both UI spots render the preferred wording in English.Non-English locale files are left untouched — translators have already chosen the correct local term for
internal-events.[CLY]_push_action, and since both UI spots now read from the same key, they will automatically stay in sync per-locale.Test plan