Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Security Fixes (backport of #7535 — bug-bounty-style hardening pass):
- [output] Remove `noescape` query-string bypass on `returnOutput` (reflected-XSS via parameter)
- [auth] Handle `req.session.regenerate` error in token login
- [data] Return 404 (not 500) when `event_groups` lookup misses
- [notes] Accept numeric color in saveNote schema so graph note create/edit no longer fails validation after H-5 enforcement (backport of #7578)
Comment thread
Cookiezaurs marked this conversation as resolved.

24.05-specific notes (some master fixes were not directly applicable):
- C-1 (`$graphLookup`) and M-11 (dbviewer non-admin filter scope): master uses a `whiteListedAggregationStages` mechanism (added by SER-2122) and a `getBaseAppFilter` per-collection app-id mechanism that 24.05 does not have. C-1 is implemented as a minimal targeted block; M-11 is not applicable here. A broader 24.05 dbviewer hardening (porting SER-2122 + filter scope + M-11) is left for a separate change.
Expand Down
9 changes: 6 additions & 3 deletions api/parts/mgmt/users.js
Original file line number Diff line number Diff line change
Expand Up @@ -901,15 +901,18 @@ usersApi.saveNote = async function(params) {
},
'ts': {
'required': true,
'type': ''
'type': 'IntegerString'
},
'noteType': {
Comment thread
Cookiezaurs marked this conversation as resolved.
'required': true,
'type': 'String',
},
'color': {
// Frontend (countly.common.notes.js COLOR_TAGS) sends a numeric
// index 1..5. URL query callers may send "5" as a string.
// Mirror the ts handling — IntegerString accepts both.
'required': true,
'type': 'String'
'type': 'IntegerString'
},
'category': {
'required': false,
Expand Down Expand Up @@ -1184,4 +1187,4 @@ usersApi.ackNotification = function(params) {
});
};

module.exports = usersApi;
module.exports = usersApi;
Comment thread
Cookiezaurs marked this conversation as resolved.