Open
Conversation
neomatamune
requested changes
Mar 17, 2026
| class TestStore: | ||
| """Tests for the store class.""" | ||
|
|
||
| def test_get_table(self, store): |
Member
There was a problem hiding this comment.
You could add a test with case sensitive names, "UPPER" and "upper" should be either the same or different tables
We need to chose the standard working here, according to sql they should be the same, but we could have user having a "File.csv" and "file.csv" living next to each other.
Current implementation would have "File" and "file" being 2 different tables in the get_table, but we need to make sure that the add_table act identical then.
Collaborator
Author
There was a problem hiding this comment.
Table FILE and file are the same in the sqlite.
All table names are store and get on lowercase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems too simple but tests are working. Did i miss something ?