fix: align agentId resolution to prevent scope mismatch (#231)#309
Open
fix: align agentId resolution to prevent scope mismatch (#231)#309
Conversation
… context memory_update/forget/stats/list were re-resolving agentId from execute-time runtimeCtx, causing scope mismatch when the execute-time context provides a different agentId than definition-time. This aligns all tools with memory_store's pattern of using the stable definition-time runtimeContext.agentId. Fixes #231 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_update,memory_forget,memory_stats, andmemory_listusedresolveRuntimeAgentId(runtimeContext.agentId, runtimeCtx)in their execute functions, which re-resolves agentId from the execute-timeruntimeCtx. When the execute-time context provides a different agentId than the definition-timeruntimeContext.agentId, this causes "Memory is outside accessible scopes" errors because the scope filter is built from a different agentId than whatmemory_storeused.resolveRuntimeAgentId(runtimeContext.agentId, runtimeCtx)withruntimeContext.agentIdin all 4 tools, aligning them withmemory_store's pattern of using the stable definition-time agentId.runtimeCtxoverride path remained in these 4 tools.Fixes #231
Test plan
npm test— 0 failures)🤖 Generated with Claude Code