refactor: extract atomic auto-capture helpers#241
refactor: extract atomic auto-capture helpers#241Victor-dw wants to merge 1 commit intoCortexReach:masterfrom
Conversation
53879d1 to
6908c73
Compare
|
Thanks for taking the time to contribute this! Really appreciate it. 🙏 There are merge conflicts with Let us know if you run into any issues! |
6908c73 to
87d2acc
Compare
|
Rebased onto the latest Current head: Validation completed locally:
Happy to rework anything else if needed. Thanks for the review. |
|
Closing — the extraction idea has merit (index.ts is 2500+ lines), but this conflicts with other PRs touching the same auto-capture area (#229, #293) which propose different decompositions. Merging this would force rebases on those PRs with potentially incompatible module boundaries. If a capture-layer refactor lands later, the ideas here can be revisited. Thanks for the effort! |
Summary
This PR extracts the atomic auto-capture path into focused helpers without changing the existing CLI surface.
Included
src/atomic-memory.tsfor a versionedatomicmetadata envelopesrc/auto-capture.tsto isolate auto-capture trigger detection, candidate extraction, and fallback persistenceindex.tsauto-capture fallback through the new helpersmemory-proCLI commands, includingmemory upgradeandreindex-ftsNot included
Why this split
The previous PR mixed three separate themes:
This PR only keeps the first two pieces so review and rollback stay simple.
Validation
npm testnode --test test/atomic-memory.test.mjsnode test/auto-capture.test.mjs