fix(settings): add hover effect to GUI/JSON settings switch#70
Open
HuiNeng6 wants to merge 2 commits intoCortexLM:mainfrom
Open
fix(settings): add hover effect to GUI/JSON settings switch#70HuiNeng6 wants to merge 2 commits intoCortexLM:mainfrom
HuiNeng6 wants to merge 2 commits intoCortexLM:mainfrom
Conversation
- Add guard in handleCopyStack to return early if frames array is empty - Disable copy button when there are no stack frames to prevent empty clipboard overwrite - Fixes issue where copy action could silently wipe user's clipboard with empty string Fixes #37588
- Remove inline style that was overriding hover effects - Add CSS class for active state with proper hover styling - Fixes issue where switch between GUI Settings and JSON editor had no visual feedback on hover Fixes #37583 (reported in PlatformNetwork/bounty-challenge)
Author
📢 跟进 — Settings hover fixMaintainers ✅ PR状态
请review。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In Settings, the control that switches between the GUI Settings Editor and the JSON Settings Editor did not show a hover state. When moving the mouse over the switch/toggle, there was no visual feedback, making it unclear which segment was under the cursor.
Root Cause
The button's hover effect was being overridden by an inline \style\ prop that set background, color, and border directly on the element. This prevented the button's built-in hover handlers from changing the background.
Solution
Testing
Fixes #37583 (reported in PlatformNetwork/bounty-challenge)