fix(debugger): disable copy button when Call Stack has no frames#69
Open
HuiNeng6 wants to merge 1 commit intoCortexLM:mainfrom
Open
fix(debugger): disable copy button when Call Stack has no frames#69HuiNeng6 wants to merge 1 commit intoCortexLM:mainfrom
HuiNeng6 wants to merge 1 commit intoCortexLM:mainfrom
Conversation
- Add guard in handleCopyStack to return early if frames array is empty - Disable copy button when there are no stack frames to prevent empty clipboard overwrite - Fixes issue where copy action could silently wipe user's clipboard with empty string Fixes #37588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In the mounted Call Stack panel, the toolbar copy action remained visible and clickable even when there were no stack frames to copy. Clicking it in that state would build an empty string and send it to the clipboard, potentially wiping user's clipboard content.
Solution
Testing
Fixes #37588 (reported in PlatformNetwork/bounty-challenge)