Implement EUR support, fallback exchange-rate provider, caching, and currency usage tracking#1
Open
olmelikov wants to merge 1 commit intoCorpEdward:mainfrom
Open
Conversation
…urrency usage tracking - add EUR support for catalog and exchange endpoints - implement exchange-rate provider abstraction - add fallback provider - add exchange rate caching - track catalog currency usage via queued job - add unit and feature tests - update README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the requested currency enhancements for the Smartphone Catalog API.
Implemented
Added EUR support
GET /api/catalog/EURGET /api/exchangeRate/EURAdded a second exchange-rate provider as fallback
Added config-driven provider selection via
config/currency.phpAdded exchange-rate caching
Added catalog currency usage tracking
Added unit and feature tests
Architecture notes
The solution uses a modular DDD-style structure for the Currency module.
Patterns used
ExchangeRateProviderInterfaceCachedExchangeRateProviderandFailoverExchangeRateProviderconfig/currency.phpDesign decisions
Test Plan
Automated
Run:
php artisan test