fix(nav): wire Hosts sidebar link + project Hosts tab#82
Merged
Conversation
- Sidebar: enable the `Hosts` entry, route to `monitoring.hosts.index` (specs 026 + 027 shipped, the page is live). - Sidebar: drop the vestigial `Pipelines` stub. Phase 4 is done and the work folded into Deployments — GitHub workflow runs are pipelines — so we ship one entry rather than maintain two views of the same data. - Project detail page: drop the "phase 6 pending" placeholder on the Hosts tab and render a project-scoped host list (mirrors the Monitoring tab). Includes "Add host" link with `?project_id=N` preselect and a "Browse all" link to the cross-project index. - ProjectController loads `projectHosts` (cap 20, with active-token flag) alongside the existing `projectMonitors`. - Test: `test_show_scopes_hosts_to_this_project` locks sibling-project isolation. Full suite 435 passing.
Hosts (`monitoring.hosts.index`) and Monitoring (`monitoring.websites.index`) both lit up at the same time because the active-detection was matching on just the first segment of the route name (`monitoring.*`). Switch to the full prefix excluding the action segment — `monitoring.hosts.*` for Hosts, `monitoring.websites.*` for Monitoring — so the two stop colliding. Single-segment routes like `overview` keep the exact-match path; nothing else regresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to specs 026 + 027 — the Hosts CRUD UI is live but the navigation paths to reach it were still gated behind "Phase 6 pending" placeholders.
Summary
Test plan
Out of scope
Container metric rendering on the host detail page — that's spec 028. This PR only wires navigation.