Skip to content

fix: add Sentinel CI workflow for workflow security scanning#236

Open
jpr5 wants to merge 1 commit into
mainfrom
sentinel-rollout/add-workflow
Open

fix: add Sentinel CI workflow for workflow security scanning#236
jpr5 wants to merge 1 commit into
mainfrom
sentinel-rollout/add-workflow

Conversation

@jpr5
Copy link
Copy Markdown
Contributor

@jpr5 jpr5 commented May 22, 2026

Summary

  • Adds .github/workflows/sentinel.yml — runs jpr5/sentinel on every PR and push to main
  • Warn-only mode (fail-on-findings: false) so existing workflows are not blocked
  • Part of org-wide Sentinel rollout (spec)

Details

Sentinel scans GitHub Actions workflows for security issues (credential exposure, unpinned actions, excessive permissions, etc.). This PR enables it in advisory mode — findings appear as annotations but do not fail the check.

Severity threshold: high (only high-severity findings are reported).

Test plan

  • Verify Sentinel check appears on this PR
  • Confirm check completes without blocking merge (fail-on-findings: false)
  • Review any findings surfaced by Sentinel on existing workflows

Comment thread .github/workflows/sentinel.yml Fixed
Comment thread .github/workflows/sentinel.yml Fixed
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@copilotkit/aimock@236

commit: d846f9e

@jpr5 jpr5 force-pushed the sentinel-rollout/add-workflow branch from 40a17be to 47ddb54 Compare May 22, 2026 20:48
@jpr5
Copy link
Copy Markdown
Contributor Author

jpr5 commented May 22, 2026

Force-pushed with SHA-pinned actions to satisfy zizmor's unpinned-uses rule. Per the org-wide sentinel rollout, the floating-tag-for-easy-updates model is being replaced with SHA-pin + dependabot. Spec updated. Rest of the PR unchanged.

Part of org-wide sentinel rollout. Warn-only mode (fail-on-findings: false).
Spec: https://www.notion.so/copilotkit/3683aa381852818bacd8e14eb7233c22
@jpr5
Copy link
Copy Markdown
Contributor Author

jpr5 commented May 22, 2026

Promoted to blocking mode — this repo had zero sentinel findings on the warn-only scan, so we're skipping the 7-day warn-only observation period. fail-on-findings is now true; future PRs that introduce critical/high findings will block merge.

@jpr5 jpr5 force-pushed the sentinel-rollout/add-workflow branch from 47ddb54 to d846f9e Compare May 22, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants