Fix label size so that it does not resize based on fontsize#3354
Merged
kasemir merged 1 commit intoControlSystemStudio:masterfrom Apr 4, 2025
Merged
Conversation
If the fontsize was larger than the widget height then the Label widget woult increase the height to fit the fontsize. This was undesired behaviour and also not the behaviour of other widgets displaying text. Now we fix the label widget to be the size defined by the user and the text will be cropped if too large for the widget.
kasemir
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the fontsize was larger than the widget height then the Label widget would increase the height to fit the fontsize. This was undesired behaviour and also not the behaviour of other widgets displaying text. For a full description of the issue see issue: #3344
Now we fix the label widget to be the size defined by the user and the text will be cropped if too large for the widget. Note that the auto size option is not affected by this change and still works as expected - i.e. in this case the size of the Label widget is changes based on the text size.