-
Notifications
You must be signed in to change notification settings - Fork 32
prevent redundant zeroMQ thread spawning by sharing a single context #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pradeeban
merged 5 commits into
ControlCore-Project:dev
from
GREENRAT-K405:fix/redundant-context-instances
Mar 1, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
90f9cad
fix redundant zmq.Context() Instances
GREENRAT-K405 7736a97
fix redundant zmq.Context() Instances
GREENRAT-K405 0c4ec88
azy-init shared context instead of one per port
GREENRAT-K405 fb27fa9
Update concore_base.py
GREENRAT-K405 0081e83
fix: move global _zmq_context declaration before first use in termina…
GREENRAT-K405 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new shared-context lifecycle (_get_zmq_context() lazy init + terminate_zmq() single term) isn’t covered by tests. Adding a unit test that asserts only one zmq.Context is created across multiple init_zmq_port calls, and that terminate_zmq resets/terminates the context (including the failure path where port creation raises and no port is registered) would help prevent regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will write tests once this PR is discussed with mentors!