fix: restore session tabs on reload, remove allgs Set divergence #359
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
fix: restore session tabs on reload, remove allgs Set divergence #359avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban I also patched ADD_GRAPH_BULK to spread initialGraphState so restored tabs don't come back half-empty. lmk if you want anything changed 🌸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #348
session restore was commented out ("on hold"). tabs were saving fine, just never loading back on refresh.
also dropped the allgs Set, it diverged from localStorage on every restart so remove/addGraph were working on stale data. everything just reads localStorage directly now.
ADD_GRAPH_BULK wasn't spreading initialGraphState so restored tabs were missing fields, fixed that too.