[QUIZ-815] - Facets as options#234
Merged
TarekAlQaddy merged 9 commits intoConstructor-io:mainfrom Jul 17, 2025
Merged
Conversation
…zzes into QUIZ-815/quiz-facets-as-options-customer-library
v-i-s-h-n-u-ps
approved these changes
Jul 10, 2025
Contributor
v-i-s-h-n-u-ps
left a comment
v-i-s-h-n-u-ps
left a comment
There was a problem hiding this comment.
@vladconstructor Changes look good. Just a couple of nitpicks. Rest will leave it to customer integrations
Comment on lines
+110
to
+112
| (currentQuestionData?.type === 'single' || | ||
| currentQuestionData?.type === 'single_filter_value') && | ||
| singleSelectClicked.current |
TarekAlQaddy
requested changes
Jul 15, 2025
…zzes into QUIZ-815/quiz-facets-as-options-customer-library
TarekAlQaddy
approved these changes
Jul 16, 2025
Contributor
TarekAlQaddy
left a comment
TarekAlQaddy
left a comment
There was a problem hiding this comment.
Approved after making sure that all tests are passing locally
mocca102
reviewed
Jul 21, 2025
| singleSelectClicked.current = true; | ||
| setSelected({ [id]: true }); | ||
| } else if (type === QuestionTypes.MultipleSelect) { | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
to avoid additional checks
Contributor
Author
There was a problem hiding this comment.
I could also put switch/case statement, but felt unnecessary for only 2 conditions
mocca102
reviewed
Jul 21, 2025
Contributor
Author
There was a problem hiding this comment.
It was an empty file
Do we need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was blocked by Constructor-io/constructorio-client-javascript#379
Introducing a new facet-based question type to ui-library.