Skip to content

[CDX-281] Mark itemName as optional in trackSearchResultClick #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esezen merged 2 commits into from
Apr 7, 2026
Merged

[CDX-281] Mark itemName as optional in trackSearchResultClick #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d909e1e
[CDX-281] Mark itemName as optional in trackSearchResultClick
quiteeasy Mar 30, 2026
46f4483
Update jsdoc
esezen Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ class Tracker {
* @function trackSearchResultClick
* @param {string} term - Search results query term
* @param {object} parameters - Additional parameters to be sent with request
* @param {string} parameters.itemName - Product item name
* @param {string} [parameters.itemName] - Product item name
* @param {string} parameters.itemId - Product item unique identifier
* @param {string} [parameters.variationId] - Product item variation unique identifier
* @param {string} [parameters.resultId] - Search result identifier (returned in response from Constructor)
Expand Down
2 changes: 1 addition & 1 deletion src/types/tracker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ declare class Tracker {
trackSearchResultClick(
term: string,
parameters: {
itemName: string;
itemName?: string;
Copy link
Copy Markdown

@constructor-claude-bedrock constructor-claude-bedrock bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: itemIsConvertible is typed as string (itemIsConvertible?: string) but the runtime implementation at src/modules/tracker.js:981 checks typeof itemIsConvertible === 'boolean'. This is a pre-existing inconsistency, but since the type signature is being touched right next to it this would be a good opportunity to fix it to boolean so that consumers receive correct compile-time guidance. This is low-risk since making it stricter is a narrowing, not a widening, of the public type.

itemId: string;
variationId?: string;
resultId?: string;
Expand Down
Loading