Skip to content

[NO-REF] - update quiz question option id to string number #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esezen merged 6 commits into from
Oct 8, 2025
Merged

[NO-REF] - update quiz question option id to string number #404

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a94572
[NO-REF] - update quiz question option id to string number
vladconstructor Oct 8, 2025
048e475
Update types
vladconstructor Oct 8, 2025
92415bf
Update src/types/quizzes.d.ts
esezen Oct 8, 2025
57211ca
Update src/types/quizzes.d.ts
esezen Oct 8, 2025
c020856
Update src/types/quizzes.d.ts
esezen Oct 8, 2025
33c110c
Add extending for base option
vladconstructor Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/types/quizzes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export interface BaseQuestion extends Record<string, any> {
export interface FilterValueQuestion extends BaseQuestion {
type: 'single_filter_value' |'multiple_filter_values';
filter_name: string;
options: QuestionOption[];
options: FilterQuestionOption[];
}

export interface SelectQuestion extends BaseQuestion {
Expand All @@ -159,8 +159,7 @@ export interface QuizResult extends Record<string, any> {
results_url: string;
}

export interface QuestionOption extends Record<string, any> {
id: number;
export interface BaseQuestionOption {
Copy link
Copy Markdown
Contributor

@esezen esezen Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the name. Is there a reason why this is not extending Record<string, any> anymore?

Copy link
Copy Markdown
Contributor Author

@vladconstructor vladconstructor Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed it since I did not see any usefulness of it
Can add it back if you have strong opinion on that

value: string;
attribute: Nullable<{
name: string;
Expand All @@ -169,6 +168,14 @@ export interface QuestionOption extends Record<string, any> {
images?: Nullable<QuestionImages>;
}

export interface QuestionOption extends BaseQuestionOption {
id: number;
}

export interface FilterQuestionOption extends BaseQuestionOption {
id: string;
}

export interface QuestionImages extends Record<string, any> {
primary_url?: Nullable<string>;
primary_alt?: Nullable<string>;
Expand Down
Loading