Skip to content

added an executor for Gossip beacon attestation reftests#10546

Merged
rolfyone merged 8 commits intoConsensys:masterfrom
rolfyone:attestation-test
Apr 14, 2026
Merged

added an executor for Gossip beacon attestation reftests#10546
rolfyone merged 8 commits intoConsensys:masterfrom
rolfyone:attestation-test

Conversation

@rolfyone
Copy link
Copy Markdown
Contributor

@rolfyone rolfyone commented Apr 2, 2026

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Low Risk
Low risk: changes are confined to eth reference-test harnesses, enabling a previously ignored gossip attestation test type and adding validation scaffolding.

Overview
Adds a new GossipBeaconAttestationTestExecutor that runs networking/gossip_beacon_attestation reftests by building an in-memory chain/fork-choice context, importing provided blocks, and validating each attestation against expected valid/reject/ignore outcomes (including duplicate and failed-block cases).

Updates GossipTests to execute these tests instead of marking them as IGNORE_TESTS.

Reviewed by Cursor Bugbot for commit 927c4f0. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just move the seenAttestationRoots.add regardless the validation result

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 80be0af. Configure here.

@rolfyone rolfyone merged commit 607545f into Consensys:master Apr 14, 2026
125 of 128 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2026
@rolfyone rolfyone deleted the attestation-test branch April 14, 2026 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants