added an executor for Gossip beacon attestation reftests#10546
Merged
rolfyone merged 8 commits intoConsensys:masterfrom Apr 14, 2026
Merged
added an executor for Gossip beacon attestation reftests#10546rolfyone merged 8 commits intoConsensys:masterfrom
rolfyone merged 8 commits intoConsensys:masterfrom
Conversation
tbenr
approved these changes
Apr 3, 2026
Contributor
tbenr
left a comment
There was a problem hiding this comment.
I'd just move the seenAttestationRoots.add regardless the validation result
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 80be0af. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Low Risk
Low risk: changes are confined to eth reference-test harnesses, enabling a previously ignored gossip attestation test type and adding validation scaffolding.
Overview
Adds a new
GossipBeaconAttestationTestExecutorthat runsnetworking/gossip_beacon_attestationreftests by building an in-memory chain/fork-choice context, importing provided blocks, and validating each attestation against expectedvalid/reject/ignoreoutcomes (including duplicate and failed-block cases).Updates
GossipTeststo execute these tests instead of marking them asIGNORE_TESTS.Reviewed by Cursor Bugbot for commit 927c4f0. Bugbot is set up for automated code reviews on this repo. Configure here.